etr2460 commented on a change in pull request #8138: [typing] add typing for
superset/connectors and superset/common
URL:
https://github.com/apache/incubator-superset/pull/8138#discussion_r318843869
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1061,12 +1078,39 @@ def query_datasources_by_name(cls, session, database,
datasource_name, schema=No
return query.all()
@staticmethod
- def default_query(qry):
+ def default_query(qry) -> Query:
return qry.filter_by(is_sqllab_view=False)
+ def has_extra_cache_keys(self, query_obj: Dict) -> bool:
Review comment:
Looks like you need to rebase off of master so this doesn't show up as a
change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
