betodealmeida commented on issue #8060: SIP-23: Persist SQL Lab state in the 
backend
URL: 
https://github.com/apache/incubator-superset/pull/8060#issuecomment-526767134
 
 
   > hi @betodealmeida I have one concern for this PR: once this feature is 
released to production, the existed sql lab users open Sql lab, they will not 
see their old query tabs and query history.
   I know the data is still in localStorage. Can we make this 
localStorage=>server-side transition more smooth? some of our sql lab users 
really, really rely on these history data.
   
   @graceguo-supercat this PR **does** migrate the existing state to the 
backend, including the query tabs and table schemas. I'm not 100% sure about 
the query history, I'll test it and if not I'll make sure to include it in the 
migration as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to