villebro commented on a change in pull request #8150: add-hana URL: https://github.com/apache/incubator-superset/pull/8150#discussion_r319710874
########## File path: superset/db_engine_specs/hana.py ########## @@ -0,0 +1,59 @@ +from superset.db_engine_specs.base import LimitMethod +from superset.db_engine_specs.postgres import PostgresBaseEngineSpec + + +class HanaPyhdbEngineSpec(PostgresBaseEngineSpec): + engine = "hana+pyhdb" Review comment: I believe this should just be `hana` (`pyhdb` in this case is just the driver, i.e. does not need to be specified separately). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
