msyavuz opened a new pull request, #39887: URL: https://github.com/apache/superset/pull/39887
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Adds an optional `color_scheme` field to the MCP `XYChartConfig` and `PieChartConfig` so LLM clients can pick a Superset color palette when generating charts. Pie's hardcoded `"supersetColors"` is now an overridable default; XY had no color control before. Wired through `map_xy_config` (via a new `add_color_scheme` helper to keep it under the C901 complexity limit) and `map_pie_config`. Example: ```json { "dataset_id": 1, "config": { "chart_type": "xy", "x": {"name": "ds"}, "y": [{"name": "val", "aggregate": "SUM"}], "kind": "line", "color_scheme": "lyftColors" } } ``` This is a minimal first slice of broader MCP chart-formatting work (number/date format, axis/data labels, dashboard-level metric color overrides) — those will follow in separate PRs. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. pytest tests/unit_tests/mcp_service/chart/test_chart_utils.py::TestMapXYConfig tests/unit_tests/mcp_service/chart/test_new_chart_types.py::TestMapPieConfig (3 new tests + existing 24 pass). 2. Via MCP generate_chart: pass "color_scheme": "lyftColors" in an XY or Pie config and confirm it lands in form_data.color_scheme; omit it on XY and confirm the key is absent (Superset default applies). ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
