rusackas commented on code in PR #39386:
URL: https://github.com/apache/superset/pull/39386#discussion_r3190385675
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -23,6 +23,10 @@ export default function exportPivotExcel(
fileName: string,
) {
const table = document.querySelector(tableSelector);
+ if (!table) {
+ console.error(`[exportPivotExcel] No element found for selector:
"${tableSelector}"`);
Review Comment:
Not sure if we NEED the error, but let's import the `logging` util and use
that (it abstracts the `console` method for safety and allows advanced features
not supported by all browsers, like `console.table`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
