matebenyovszky commented on PR #39171: URL: https://github.com/apache/superset/pull/39171#issuecomment-4382444744
Hey @michael-s-molina @villebro @rusackas @geido @kgabryje 👋 We at [Integrity Authority Hungary](https://github.com/integrityauthority) are actively building a Superset extension — **Vambery AI Assistant** (see our [superset-extensions](https://github.com/integrityauthority/superset-extensions) repo) — and the Storage API from this PR is exactly what we need for persisting conversation state, user preferences, and AI context across sessions. We're ready to adopt this as soon as it lands. While reviewing the code to prepare for integration, I found a **breaking bug** (see my comment above): the frontend URL builder wasn't updated to match the restructured backend routes from `f08bcd4`. I've prepared a complete patch (bug fix + unit tests for all 3 storage modules) that can be applied in one command: `ash curl -sL https://gist.githubusercontent.com/matebenyovszky/f64b21f895a34289171fd18fe381e85b/raw/fix-storage-urls-and-add-tests.patch | git am ` **What the patch fixes:** - 🐛 Frontend `ephemeralState.ts` and `persistentState.ts` URL paths → aligned with backend `/<publisher>/<name>/storage/...` routes - ✅ Added ~490 lines of unit tests for `localState`, `ephemeralState`, and `persistentState` (should help with the codecov check) **What we think is still needed to unblock this PR:** 1. Apply the patch above (or I can open a PR against your branch) 2. Mark as "Ready for Review" (currently draft) 3. @villebro — your earlier comments have all been addressed by Michael, would be great if you could re-review! This is a really well-designed module — the tiered storage approach with automatic namespace isolation is exactly the right pattern for extensions. Would love to see it merged soon! 🚀 cc @aminghadersohi @betodealmeida -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
