bito-code-review[bot] commented on PR #39906:
URL: https://github.com/apache/superset/pull/39906#issuecomment-4386982108
<!-- Bito Reply -->
The flagged issue is correct: adding the cross_filter_column control to
GeoJSON without updating the query to include the selected column causes a
mismatch, leading to fallback filters. To resolve, update Geojson/buildQuery.ts
to include cross_filter_column in queried columns, similar to Polygon layer. No
other comments found in the PR.
**superset-frontend/plugins/preset-chart-deckgl/src/layers/Geojson/buildQuery.ts**
```
export interface DeckGeojsonFormData extends SqlaFormData {
// ... existing fields
cross_filter_column?: string | null;
}
export default function buildQuery(formData: DeckGeojsonFormData) {
const {
// ... existing destructuring
cross_filter_column,
} = formData;
// ... existing code
if (cross_filter_column && !columns.includes(cross_filter_column)) {
columns.push(cross_filter_column);
}
// ... rest
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
