richardfogaca commented on PR #39885: URL: https://github.com/apache/superset/pull/39885#issuecomment-4387880033
Small suggestion before merge: the `stripHtmlToText` cache is a nice improvement, but `htmlTextComparator` still calls `isProbablyHTML()` on each comparison, and that helper also does `DOMParser` work for HTML-looking strings. Would it be worth caching the normalized comparator value per raw string, so each unique HTML cell only pays the detection/parsing cost once during sort? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
