aminghadersohi commented on PR #39921: URL: https://github.com/apache/superset/pull/39921#issuecomment-4393037935
Thanks for the review! All three points addressed in the follow-up commit (546c805): 1. **Misleading comment** — Removed the specific reference to `validate_chart_dataset()`. The comment now describes SQLAlchemy's general expire-on-commit behaviour as the source of detachment, without fingering a specific function. 2. **MagicMock URLPreview in test** — Replaced the `MagicMock` stub with a real `URLPreview` instance so Pydantic's discriminated-union validation on `ChartPreview.content` passes cleanly. Added assertions that the response contains `chart_id` (not `error_type`) to confirm the happy path is actually exercised. 3. **logger.error drops traceback** — Changed to `logger.exception(...)` so the full stack trace is captured alongside the `ctx.error` message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
