massucattoj opened a new pull request, #39924: URL: https://github.com/apache/superset/pull/39924
### SUMMARY In the Explore filter popover (Simple tab), when a unary operator was selected (`IS NULL`, `IS NOT NULL`, `IS TRUE`, `IS FALSE`), the value input below the operator dropdown was rendered in a disabled (grayed-out) state instead of being hidden. Disabled inputs that can never be interacted with create visual noise and confuse users about what is required to complete the filter. This change hides the value control entirely whenever the selected operator appears in `DISABLE_INPUT_OPERATORS`, so only the column and operator fields are shown for unary operators. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF **Before:** <img width="380" height="336" alt="Screenshot 2026-05-06 at 22 11 50" src="https://github.com/user-attachments/assets/990b135b-da56-4928-986a-43e4bc1ec7be"; /> **After:** <img width="370" height="332" alt="Screenshot 2026-05-06 at 22 10 58" src="https://github.com/user-attachments/assets/98066044-3e84-4d18-86e3-85a6d06d930c"; /> <!-- attach the before/after screenshots here --> ### TESTING INSTRUCTIONS 1. Open any chart in Explore (e.g. a Table chart on `birth_names` or any dataset). 2. In the **FILTERS** section, click an existing filter or `+ Add filter`. 3. Switch to the **SIMPLE** tab. 4. Pick any column. 5. Change the operator to `Is null`, `Is not null`, `Is true`, or `Is false`. 6. **Expected:** the value input below the operator does **not** render at all (previously it rendered as a disabled/grayed input). 7. Switching back to a non-unary operator (e.g. `Equal to`, `In`) should restore the value input. Automated coverage: see four new tests in `AdhocFilterEditPopoverSimpleTabContent.test.tsx` asserting that the value input is not in the document for each unary operator. ### ADDITIONAL INFORMATION - [ ] Has associated issue: <!-- fill in if a GH issue exists --> - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
