HaroldWrenFinch commented on PR #30827:
URL: https://github.com/apache/superset/pull/30827#issuecomment-4396297649
> @HaroldWrenFinch — this one has gone stale and now conflicts with master.
The change is small (+8/-1) and CI was green before the conflict appeared.
Could you rebase on `master` and resolve, and ideally add a quick test for the
not-filterable cross-filter behavior? Once it's clean we can get a maintainer
to take a fresh look. Let us know if you'd rather we close it.
Hi @rusackas, thanks for the patience and the nudge!
I've rebased onto the latest master and resolved the conflicts. I also
added a unit test for the not-filterable cross-filter behavior in
TableChart.test.tsx.
Ready for another look. 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
