mikebridge commented on PR #39859: URL: https://github.com/apache/superset/pull/39859#issuecomment-4398926547
> Hi folks. I'm attending an onsite and don't have much availability this week. At Airbnb, we have tables like `query`, `logs` , and `key_value` with millions of rows. Migrations like the ones proposed in this PR are a significant problem for us due to the downtime required to upgrade. Is the current PK structure blocking anything or is it just an improvement to the schema? Hey @michael-s-molina! Yes, this will only touch the join tables that join to users/dashboards/charts/roles so the cardinality should be quite a bit lower than for something like logging. We can touch base when you have some time and maybe I can get some data from you that will help me gauge impact. My hypothesis is that the worst-case scenario is under two minutes. One big side-issue here is fixing the data-integrity vulnerabilities with the missing `UNIQUE` and `NOT NULL` constraints. Anyway, a subset of this R is to remove a blocker for Versioning, but it's not strictly necessary to fix _every_ table in this iteration. Ideally I'd like to fix all eight tables at once though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
