Aitema-gmbh commented on PR #39237: URL: https://github.com/apache/superset/pull/39237#issuecomment-4399020134
Hi @rusackas — after weighing this against the bot review and your concern about collision with the planned mobile work, we've decided to close this PR rather than push it forward upstream. Three reasons: 1. The breakpoint choice (320px) is genuinely contentious. WCAG 1.4.10 requires reflow at 320px, but Superset's roadmap targets larger mobile breakpoints (768px+). Forcing 320px reflow now would conflict with the mobile team's design direction, and the bot reviews (`100vw` overflow, fixed sidepane covering header, native filter unreachable on small screens, mobile sidebar shrinking content to zero) all point at the difficulty of doing this layout-wide without coordination. 2. The 320px reflow lives in our internal fork, where it's tied to a specific deployment context. Open-sourcing the layout shifts now risks committing the project to a smaller-than-planned breakpoint before the mobile team has weighed in. 3. We'd rather wait for the mobile design to land and then revisit reflow as a coordinated change, where the breakpoint is part of the mobile spec rather than an a11y-only retrofit. Happy to reopen or contribute to the mobile-design conversation when that work picks up. Thanks again for the careful review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
