Vitor-Avila opened a new pull request, #39953: URL: https://github.com/apache/superset/pull/39953
### SUMMARY This is a follow up to https://github.com/apache/superset/pull/39538. While the initial PR solved one issue for un-aggregated tables, further using the dialect exposed a bigger issue. The `elasticsearch-dbapi` driver was removing any `"` from the queries, causing issues for metric/column labels like `my metric`. I simplified the `sanitize_query` method for the `elasticsearch-dbapi` driver [here](https://github.com/preset-io/elasticsearch-dbapi/pull/121), so this PR bumps the package version in Superset while also defaulting to backticks as the identifier delimiter (the official one according to OpenSearch/OpenDistro docs). Double quotes are still supported in the dialect since the DBs support it as well. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS 1. Create a dataset powered by OpenSearch/OpenDistro. 2. Create a metric in the dataset using `count(*)` and `my metric` as the key. 3. Create a chart using this metric. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
