abderbejaoui commented on PR #38490: URL: https://github.com/apache/superset/pull/38490#issuecomment-4402207260
Hi @villebro , just following up on this PR. I addressed the requested changes regarding the cache timeout validation behavior: * `cache_timeout` now correctly allows `-1` for cache bypass * values below `-1` are rejected * `schema_cache_timeout` and `table_cache_timeout` remain non-negative only * added frontend/backend validation and test coverage for all cases All CI checks are now passing except for the cancelled pre-commit workflow runs. Would appreciate another review whenever you have time. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
