sadpandajoe opened a new pull request, #39957:
URL: https://github.com/apache/superset/pull/39957

   ## Summary
   - The `SemanticLayerModal` test introduced in #37815 hangs forever, causing 
shard 6 of the frontend test suite to time out after 3+ hours
   - The test uses fake timers to control a debounce, but our test environment 
patches out `MessageChannel` (to work around an rc-overflow issue). Without 
`MessageChannel`, React falls back to `setTimeout` for scheduling renders — and 
fake timers block those too, so React never re-renders and the test never 
finishes
   - Fix: tell Jest to auto-advance fake timers (`advanceTimers: true`), which 
unblocks React's render scheduling while still letting the test explicitly 
control the 500ms debounce
   - Also reorder the `DatasetList.test.tsx` cleanup to restore real timers 
before flushing async work, so a test failure mid-run can't cause the same kind 
of hang
   
   ## Test plan
   - [x] `SemanticLayerModal.test.tsx` passes in ~14s (was hanging indefinitely)
   - [x] All 28 `DatasetList.test.tsx` tests pass
   - [ ] Shard 6/8 completes in CI without timeout
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to