alexandrusoare opened a new pull request, #39964: URL: https://github.com/apache/superset/pull/39964
### SUMMARY **Problem:** When a database is unreachable, MCP's `generate_chart` tool tells the user "Chart query failed to execute. The chart configuration is invalid" with suggestions like "Check that all columns exist." Users see this and think their chart config is wrong — when the real problem is the database is down. **Root cause:** `_compile_chart()` in `compile.py` already classifies database errors correctly and returns a structured `error_obj` with the right error type and message. But `generate_chart.py` was ignoring `error_obj` entirely — it threw it away and constructed a new hardcoded error with `error_type="compile_error"` and generic suggestions every time, regardless of what actually failed. **Solution:** Use `compile_result.error_obj` when available instead of hardcoding a new error. Fall back to the generic compile error only if `error_obj` is None. Also added `_classify_as_database_error()` in `compile.py` which uses Superset's existing `db_engine_spec.extract_errors()` to detect database errors — the same classification the UI uses. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
