codeant-ai-for-open-source[bot] commented on code in PR #39964:
URL: https://github.com/apache/superset/pull/39964#discussion_r3208216900
##########
superset/mcp_service/chart/compile.py:
##########
@@ -46,6 +49,21 @@
logger = logging.getLogger(__name__)
+_CONNECTION_ERROR_TYPES = {
+ SupersetErrorType.CONNECTION_INVALID_USERNAME_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PASSWORD_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_HOSTNAME_ERROR,
+ SupersetErrorType.CONNECTION_PORT_CLOSED_ERROR,
+ SupersetErrorType.CONNECTION_INVALID_PORT_ERROR,
+ SupersetErrorType.CONNECTION_HOST_DOWN_ERROR,
+ SupersetErrorType.CONNECTION_ACCESS_DENIED_ERROR,
+ SupersetErrorType.CONNECTION_UNKNOWN_DATABASE_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_PERMISSIONS_ERROR,
+ SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
+ SupersetErrorType.CONNECTION_DATABASE_TIMEOUT,
+ SupersetErrorType.GENERIC_DB_ENGINE_ERROR,
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Keep `SupersetErrorType.GENERIC_DB_ENGINE_ERROR` in the connection-error
allowlist for chart compilation so engines without specific `CONNECTION_*`
patterns still surface real database connection failures correctly.
**Applied to:**
- `superset/mcp_service/chart/**`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
