mikebridge commented on PR #39973: URL: https://github.com/apache/superset/pull/39973#issuecomment-4409115762
**Note on the Codecov 66.67% patch coverage warning** Both Codecov gates (`codecov/patch`, `codecov/project`) pass. The warning comes from the per-flag breakdown: - **unit flag: 100%** — `tests/unit_tests/commands/report/execute_test.py::test_get_url_raises_unexpected_error_when_target_is_missing` covers every new line. - **python / postgres / mysql / sqlite (integration) flags: 66.66%** — integration tests can't reach the dual-None state by design. The codepath the new guard protects (both `chart` and `dashboard` returning `None` from the relationship) is *intentionally unreachable* in production: `DeleteChartCommand` and `DeleteDashboardCommand` already block deletion of a target that has reports referencing it. The guard is defense-in-depth — it activates only if a future code path or a direct SQL write ever produces an orphaned report. Constructing that state cleanly from an integration test would require bypassing the very validation the guard protects against. Project coverage actually rose by +0.06% with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
