mikebridge commented on PR #39286: URL: https://github.com/apache/superset/pull/39286#issuecomment-4409672224
**Closing as superseded by a decomposition into smaller PRs.** Per reviewer feedback that this work should land in smaller, more reviewable pieces, the soft-delete change is being split into independent PRs under epic [Versioning (sc-103155)](https://app.shortcut.com/preset/epic/103155): | PR | Story | Description | Status | |---|---|---|---| | [#39973](https://github.com/apache/superset/pull/39973) | [sc-106186](https://app.shortcut.com/preset/story/106186) | `fix(reports): null-guard execution against missing target` | Open, ready for review | | [#39977](https://github.com/apache/superset/pull/39977) | [sc-106188](https://app.shortcut.com/preset/story/106188) | `feat(core): SoftDeleteMixin and restore infrastructure` | Open, ready for review | | (forthcoming) | [sc-106189](https://app.shortcut.com/preset/story/106189) | `feat(charts): soft-delete and restore for charts` | Prepped, opens after #39977 merges | | (forthcoming) | [sc-106190](https://app.shortcut.com/preset/story/106190) | `feat(dashboards): soft-delete and restore for dashboards` | Prepped, opens after #39977 merges | | (forthcoming) | [sc-106191](https://app.shortcut.com/preset/story/106191) | `feat(datasets): soft-delete and restore for datasets` | Prepped, opens after #39977 merges | The original [SIP-208 (#39464)](https://github.com/apache/superset/issues/39464) is approved and covers all five PRs. Any review feedback you intended to leave here, please leave on the relevant PR above. The original branch (`sc-103157-soft-deletes`) and this PR are kept alive as the source-of-truth diff that the carving was done against; once the four split PRs merge, the branch will be deleted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
