rusackas commented on code in PR #38162:
URL: https://github.com/apache/superset/pull/38162#discussion_r3211835893
##########
superset-frontend/packages/superset-ui-core/src/components/DropdownContainer/DropdownContainer.tsx:
##########
@@ -293,6 +297,45 @@ export const DropdownContainer = forwardRef(
};
}, [popoverVisible]);
+ const triggerButton = (
+ <Tooltip title={dropdownTriggerTooltip}>
+ <Button
+ buttonStyle="secondary"
+ data-test="dropdown-container-btn"
+ icon={dropdownTriggerIcon}
+ disabled={!popoverContent}
+ css={css`
+ padding-left: ${theme.paddingXS}px;
+ padding-right: ${theme.paddingXXS}px;
+ gap: ${theme.sizeXXS}px;
+ `}
+ >
Review Comment:
Already addressed in bf6e779 — switched to the `Button` component's built-in
`tooltip` prop, which wraps disabled buttons in a `<span>` so hover/focus
reaches the tooltip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
