bito-code-review[bot] commented on code in PR #39977:
URL: https://github.com/apache/superset/pull/39977#discussion_r3212137748
##########
superset/models/helpers.py:
##########
@@ -654,7 +655,94 @@ def created_on_humanized(self) -> str:
@renders("changed_on")
def modified(self) -> Markup:
- return Markup(f'<span
class="no-wrap">{self.changed_on_humanized}</span>')
+ return Markup(f'<span
class="no-wrap">{self.changed_on_humanized}</span>') # noqa: S704
+
+
+SKIP_VISIBILITY_FILTER = "skip_visibility_filter"
+
+
+class SoftDeleteMixin:
+ """Mixin that adds soft-delete support to a SQLAlchemy model.
+
+ Adds a nullable ``deleted_at`` column. When set, the row is treated as
+ deleted and excluded from standard ORM queries via a global
+ ``do_orm_execute`` listener registered at app init.
+
+ Delete commands should call ``soft_delete()`` to mark the object as
+ deleted. Use ``BaseDAO.delete()`` (which calls ``session.delete()``)
+ for permanent hard deletion.
+
+ See also: ``_add_soft_delete_filter`` (the listener function) and
+ ``SKIP_VISIBILITY_FILTER`` (the execution-option key used to opt out
+ of the filter in restore commands and admin tooling).
+ """
+
+ deleted_at = sa.Column(sa.DateTime, nullable=True, index=True)
+
+ @hybrid_property
+ def is_deleted(self) -> bool:
+ return self.deleted_at is not None
+
+ @is_deleted.expression # type: ignore
+ def is_deleted(cls) -> ColumnElement: # noqa: N805
+ return cls.deleted_at.is_not(None)
+
+ @classmethod
+ def not_deleted(cls) -> ColumnElement:
+ """Filter clause for active (non-deleted) rows."""
+ return cls.deleted_at.is_(None)
+
+ def soft_delete(self) -> None:
+ """Mark this object as soft-deleted."""
+ # Naive datetime, mirroring AuditMixinNullable.changed_on. PR #33693
+ # reverted a UTC migration on the audit columns; if/when those move
+ # to UTC-aware, this assignment should follow.
+ self.deleted_at = datetime.now()
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>datetime.now() called without timezone</b></div>
<div id="fix">
Replace `datetime.now()` with `datetime.now(tz=pytz.utc)` or
`datetime.now(tz=timezone.utc)` to ensure timezone-aware datetime objects.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
def soft_delete(self) -> None:
"""Mark this object as soft-deleted."""
# Naive datetime, mirroring AuditMixinNullable.changed_on. PR #33693
# reverted a UTC migration on the audit columns; if/when those move
# to UTC-aware, this assignment should follow.
self.deleted_at = datetime.now(tz=pytz.utc)
````
</div>
</details>
</div>
<small><i>Code Review Run #096e88</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
