bito-code-review[bot] commented on PR #40000:
URL: https://github.com/apache/superset/pull/40000#issuecomment-4415836417
<!-- Bito Reply -->
The flagged issue is correct: applying `applyTimeGrainAllowlist` to chart
customizations at the data-fetch layer removes selected values outside the
allowlist before the plugin can preserve them, causing visibility loss in
edited dashboards.
To resolve, modify the condition in `applyTimeGrainAllowlist` to exclude
`chart_customization_timegrain`, keeping fetch-time filtering only for native
filters.
No other comments found in the PR.
**superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx**
```
if (filterType !== 'filter_timegrain' || !allowedTimeGrains?.length) {
return results;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
