alexandrusoare opened a new pull request, #40020: URL: https://github.com/apache/superset/pull/40020
### SUMMARY The get_chart_preview response duplicates data — the same ASCII/table content appears in both content.ascii_content (or content.table_data) AND in flat top-level fields (ascii_chart, table_data). Both copies also get sanitized independently, wasting work. Solution: Remove the redundant flat fields (format, ascii_chart, table_data, width, height) from ChartPreview. Clients should read from the content discriminated union, which already has all of this data via ASCIIPreview, TablePreview, etc. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
