felipegr0ssi opened a new pull request, #40032:
URL: https://github.com/apache/superset/pull/40032

   ### SUMMARY
   Fixes #34135.
   
   Dashboard Value filters previously mounted the select dropdown into the 
input's parent element. On short viewports or high browser zoom, that relative 
container can place the dropdown over the trigger field and hide the current 
input. This changes dashboard filter selects to mount their popup under 
`document.body`, while preserving the existing parent-container behavior for 
the filter config modal and overflow filter menu.
   
   A unit test verifies dashboard select dropdowns are portaled to 
`document.body`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   See the linked issue for the before screenshot.
   
   ### TESTING INSTRUCTIONS
   1. Open the example Sales Dashboard.
   2. Reduce the browser height or increase browser zoom.
   3. Open a dashboard Value filter.
   4. Confirm the dropdown no longer overlaps and hides the select input.
   
   Local checks run:
   - `npx [email protected] --check 
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx 
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx`
   - `npx [email protected] --quiet --config superset-frontend/oxlint.json 
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx 
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx` (0 
errors)
   - `git diff --check`
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #34135
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to