bito-code-review[bot] commented on code in PR #40037:
URL: https://github.com/apache/superset/pull/40037#discussion_r3221736842
##########
superset-frontend/src/SqlLab/components/ExploreCtasResultsButton/index.tsx:
##########
@@ -55,8 +56,12 @@ const ExploreCtasResultsButton = ({
};
const visualize = () => {
- dispatch(createCtasDatasource(buildVizOptions))
- .then((data: { table_id: number }) => {
+ (
+ dispatch(createCtasDatasource(buildVizOptions)) as unknown as Promise<{
+ table_id: number;
+ }>
+ )
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type Mismatch in Action Return</b></div>
<div id="fix">
The createCtasDatasource action's return type is incorrect; it declares
Promise<{ id: number }> but the API actually returns { table_id: number }, as
evidenced by the test mock and code accessing data.table_id. This type mismatch
could cause confusion or errors if the type is relied upon elsewhere. Fix the
action's type annotation to match the actual API response.
</div>
</div>
<small><i>Code Review Run #f5109e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
