villebro opened a new pull request, #45: URL: https://github.com/apache/superset-kubernetes-operator/pull/45
## Summary Fixes several issues discovered while testing the clone feature with cron scheduling: - **Drain loop after lifecycle completion**: The reconciler would drain components on every reconcile even after tasks completed, because `drainIfNeeded` ran before checking task completion. Added a fast-path checksum comparison (`allTasksStillComplete`) that skips drain when all enabled tasks already completed with matching checksums. Also persist lifecycle status immediately after completion (before creating components) to prevent conflicts from losing `lastCompletedChecksums`. - **Clone pod not executing command**: `convertCloneComponent` did not inject the clone shell script into the container's `Command` field, causing the `postgres:17-alpine` image to run its default entrypoint (PostgreSQL server startup) instead of `pg_dump | psql`. - **Maintenance page redirect loop**: The nginx config used `index index.html` which caused an internal redirect to `/index.html`, matching the catch-all `location /` that 302'd back to `/`. Replaced with `try_files`. - **`postCloneSQL` field**: New field on `CloneTaskSpec` for executing SQL statements against the target database after cloning (e.g., disabling alerts, deleting OAuth tokens). Included in checksum inputs so changes trigger re-execution. - **Pod retention default changed to `Retain`**: Lifecycle task pods are now kept after completion by default for log inspection. They are automatically cleaned up by GC when the task CR is deleted on the next lifecycle run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
