7jin16 opened a new pull request, #40041:
URL: https://github.com/apache/superset/pull/40041

   ### SUMMARY
   Fixes #33905.
   
   Monthly time-series axes were using the same 31-day duration for ECharts 
minInterval and maxInterval. Because minInterval is a lower bound between 
ticks, that can make month-start ticks after 30-day months ineligible, which 
can hide the final monthly label.
   
   This PR separates the minInterval mapping from the existing timestamp 
mapping used by maxInterval. The minInterval mapping uses the shortest possible 
calendar interval for coarse grains while preserving the existing maxInterval 
behavior.
   
   ### TESTING
   - 
PATH=/opt/homebrew/opt/node@22/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pkg/env/active/bin:/opt/pmk/env/global/bin:/Library/Apple/usr/bin:/Users/gg/.codex/tmp/arg0/codex-arg0KHNPdy:/opt/homebrew/opt/libpq/bin:/Users/gg/.nvm/versions/node/v20.20.0/bin:/Applications/Codex.app/Contents/Resources
 npm test -- --runTestsByPath 
plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
   - 
PATH=/opt/homebrew/opt/node@22/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pkg/env/active/bin:/opt/pmk/env/global/bin:/Library/Apple/usr/bin:/Users/gg/.codex/tmp/arg0/codex-arg0KHNPdy:/opt/homebrew/opt/libpq/bin:/Users/gg/.nvm/versions/node/v20.20.0/bin:/Applications/Codex.app/Contents/Resources
 npm run lint -- plugins/plugin-chart-echarts/src/constants.ts 
plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts 
plugins/plugin-chart-echarts/src/MixedTimeseries/transformProps.ts 
plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
   - git diff --check


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to