kasiazjc opened a new pull request, #40062: URL: https://github.com/apache/superset/pull/40062
### SUMMARY Replaces `<span role="button">` and `<div role="button">` patterns with proper `<Button>` or native `<button>` components across 13 files. Non-button elements with `role="button"` lack automatic keyboard activation (Enter/Space), built-in focus rings, and correct ARIA semantics. Files changed: - `explore/components/DataTableControl/index.tsx` - `explore/components/ExploreChartPanel/index.tsx` - `explore/components/ExploreViewContainer/index.tsx` - `explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx` - `explore/components/controls/MetricControl/AdhocMetricEditPopover/index.tsx` - `features/dashboards/DashboardCard.tsx` - `features/datasets/AddDataset/DatasetPanel/DatasetPanel.tsx` - `features/datasets/AddDataset/DatasetPanel/MessageContent.tsx` - `features/queries/QueryPreviewModal.tsx` - `features/queries/SyntaxHighlighterCopy.tsx` - `features/tags/TagCard.tsx` Notable approaches: - `<Button buttonStyle="link">` for inline text/icon actions - `styled.button` for `QueryPreviewModal`'s tab toggles (already styled, just wrong element type) - Removed redundant `onKeyDown` handlers that Button handles natively - Added `aria-label` to icon-only buttons ### TESTING INSTRUCTIONS 1. Verify all affected components are keyboard-navigable (Tab to focus, Enter/Space to activate) 2. Check that focus rings appear correctly on all converted elements 3. Specifically test: Copy button in DataTableControl, "Create a dataset" links in Explore, sidebar toggle in ExploreViewContainer, column config show-more button, dashboard/tag card action menus ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
