bito-code-review[bot] commented on code in PR #40055:
URL: https://github.com/apache/superset/pull/40055#discussion_r3226272211
##########
docs/yarn.lock:
##########
@@ -5166,6 +5204,21 @@
tinyglobby "^0.2.15"
ts-api-utils "^2.5.0"
+"@typescript-eslint/[email protected]":
+ version "8.59.3"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.59.3.tgz#e6bb1408e00b47e431427a40268db4e86cb121ab";
+ integrity
sha512-CbRjVRAf7Lr9Kr8RopKcbY45p2VfmmHrm0ygOCYFi7oU8q19m0Fs/6iHS7kNOmwpp+ob07ZVcAqlxUod9lYdmg==
+ dependencies:
+ "@typescript-eslint/project-service" "8.59.3"
+ "@typescript-eslint/tsconfig-utils" "8.59.3"
+ "@typescript-eslint/types" "8.59.3"
+ "@typescript-eslint/visitor-keys" "8.59.3"
+ debug "^4.4.3"
+ minimatch "^10.2.2"
+ semver "^7.7.3"
+ tinyglobby "^0.2.15"
+ ts-api-utils "^2.5.0"
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Lock File Manual Edit</b></div>
<div id="fix">
The yarn.lock file has been manually edited by adding new package entries
for @typescript-eslint/[email protected]. According to repository
standards, lock files should never be manually edited; instead, update
package.json and run the package manager to regenerate the lock file. This
ensures integrity hashes are correctly calculated and dependency resolution
follows the package manager's algorithm.
</div>
</div>
<small><i>Code Review Run #ea1d4e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
docs/yarn.lock:
##########
@@ -5184,6 +5237,14 @@
"@typescript-eslint/types" "8.59.2"
eslint-visitor-keys "^5.0.0"
+"@typescript-eslint/[email protected]":
+ version "8.59.3"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.59.3.tgz#820843b1b5ca4290009cf189382abcf6fe00dfa6";
+ integrity
sha512-f1UQF7ggd42YiwI5wGrRaPsa+P0CINBlrkLPmGfpq/u/I/oVtecoEIfFR9ag/oa1sLOsRNZ6xehf6qMZhQGBDg==
+ dependencies:
+ "@typescript-eslint/types" "8.59.3"
+ eslint-visitor-keys "^5.0.0"
+
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Lock File Manual Edit</b></div>
<div id="fix">
The yarn.lock file has been manually edited by adding new package entries
for @typescript-eslint/[email protected]. According to repository standards,
lock files should never be manually edited; instead, update package.json and
run the package manager to regenerate the lock file. This ensures integrity
hashes are correctly calculated and dependency resolution follows the package
manager's algorithm.
</div>
</div>
<small><i>Code Review Run #ea1d4e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
