bito-code-review[bot] commented on PR #40062:
URL: https://github.com/apache/superset/pull/40062#issuecomment-4430396217
<!-- Bito Reply -->
Yes, the suggestion is valid — switching TabButton from a styled div to a
native button element without resetting browser default styles (like border and
background) will cause visible style regressions, such as unexpected borders
and spacing in the Query Preview modal tabs.
**superset-frontend/src/features/queries/QueryPreviewModal.tsx**
```
const TabButton = styled.button`
border: none;
background: transparent;
font: inherit;
color: inherit;
cursor: pointer;
font-size: ${({ theme }) => theme.fontSizeSM}px;
padding: ${({ theme }) => theme.sizeUnit * 2}px
${({ theme }) => theme.sizeUnit * 4}px;
// ... rest of existing styles
`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
