bito-code-review[bot] commented on code in PR #40062:
URL: https://github.com/apache/superset/pull/40062#discussion_r3226342448
##########
superset-frontend/src/features/datasets/AddDataset/DatasetPanel/MessageContent.tsx:
##########
@@ -52,9 +52,7 @@ const renderEmptyDescription = () => (
<>
{SELECT_MESSAGE}
<Link to="/sqllab">
- <span role="button" tabIndex={0}>
- {CREATE_MESSAGE}
- </span>
+ {CREATE_MESSAGE}
</Link>
{VIEW_DATASET_MESSAGE}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Test assertion mismatch</b></div>
<div id="fix">
The removal of the <span role="button" tabIndex={0}> wrapper improves
semantic correctness, as the element is a navigation link, not a button.
However, this breaks the test assertion in DatasetPanel.test.tsx that expects
getByRole('button'). Update the test to use getByRole('link', { name:
CREATE_MESSAGE }) to match the correct semantics.
</div>
</div>
<small><i>Code Review Run #7af5e7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
