kasiazjc commented on PR #40062: URL: https://github.com/apache/superset/pull/40062#issuecomment-4430662389
## Playwright visual audit — `polish-ux-03-role-button` Ran Playwright against the live branch environment to verify the `role=button` → `<Button>` replacements render correctly and pass a DOM accessibility audit. ### DOM audit: `span/div[role="button"]` on non-button elements introduced by this PR | Page | Extra `role=button` non-buttons from **this PR** | |---|---| | Chart card view | **0** ✅ | | Dashboard card view | **0** ✅ | | Explore page | **0** ✅ | | Add Dataset page | **0** ✅ | The only remaining `role=button` non-buttons in the DOM are pre-existing (antd `Select`/`Collapse` internals, the view-mode toggle divs, and the toast close icon — none of them are in the 13 files changed by this PR). --- ### Chart card view — Edit / Export / Delete menu Previously `<div role="button">`, now real `<button>` elements with keyboard activation:  Dropdown zoomed:  --- ### Dashboard card view Same fix, same clean result:   --- ### Explore page — datasource sidebar collapse/expand buttons Previously `<span role="button">` and `<div role="button">`, now proper `<Button>` components. Both states work: **Sidebar open** (collapse arrow is now a real button):  **Sidebar collapsed** (expand tab is now a real button):  --- ### Add Dataset page — MessageContent link Previously `<span role="button">` inside a `<Link>`, now the link renders cleanly with no redundant wrapper:  --- *Screenshots captured via Playwright headless Chromium against the live branch environment.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
