pbfrias17 commented on issue #40070: URL: https://github.com/apache/superset/issues/40070#issuecomment-4432257419
After stepping through the code, it looks like this is where we try to set the query limit: https://github.com/apache/superset/blob/c9fb1bc10fc06a10d367d77a93cf9f904713db2c/superset/commands/sql_lab/execute.py#L154-L157 But this is the part of the update method that is being executed https://github.com/apache/superset/blob/c9fb1bc10fc06a10d367d77a93cf9f904713db2c/superset/daos/base.py#L429. I would think it should call the `merge` function since we're [saving a new query object just before trying to update the limit](https://github.com/apache/superset/blob/c9fb1bc10fc06a10d367d77a93cf9f904713db2c/superset/commands/sql_lab/execute.py#L145) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
