rusackas commented on PR #40034: URL: https://github.com/apache/superset/pull/40034#issuecomment-4433090533
This relates closely to https://github.com/apache/superset/pull/39782 - that one looks at the tests, but "works around" the implementation without testing the actual code path this addresses. However, as noted by bots, this PR changes the import to `from datetime import UTC, datetime, timedelta`. `datetime.UTC` was introduced in Python 3.11, but Superset supports Python 3.10. This will cause an `ImportError` at module load on 3.10 machines and break startup entirely. The correct alternative for cross-version compatibility is `from datetime import timezone` and then `timezone.utc`, or `import datetime; datetime.timezone.utc`. Hopefully that'll work, but if not, it may be time to consider making the case for a 3.11 requirement, which could be a "beaking change" requiring waiting for a major version. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
