villebro opened a new pull request, #49:
URL: https://github.com/apache/superset-kubernetes-operator/pull/49
## Summary
Addresses remaining findings from external code review, bundled as a single
housekeeping PR:
- **Default health probes (medium):** Web-server (`/health`), Celery Flower
(`/api/workers`), websocket server (`/health`), and MCP server (TCP) now ship
with default liveness and readiness probes. Users can override via
`podTemplate.container.{liveness,readiness,startup}Probe`. "Ready" now means
the application is actually serving, not just that the container started.
- **WebsocketServer image docs (medium):** Added a warning that
`websocketServer` requires a dedicated Node.js image (the default Superset
image doesn't contain `websocket_server.js`). Points to
`oneacrefund/superset-websocket` as an experimental community option.
- **Helm RBAC sync (low):** Helm ClusterRole now matches the generated
`config/rbac/role.yaml` — fixed API group (`events.k8s.io` not core), added
missing `update` verb on events, and unified status sub-resource grouping.
- **Child CR sample naming (low):** Renamed child samples from
`superset-sample-{component}` to `superset-sample` (parent-style names) to
avoid double-suffixed sub-resources like
`superset-sample-web-server-web-server`.
- **Docs polish (low):** Fixed websocket port (8088→8080), documented all
three environment modes (Production/Staging/Development) with their validation
semantics, populated `status.configChecksum` (was declared but never set).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
