rusackas commented on PR #39461:
URL: https://github.com/apache/superset/pull/39461#issuecomment-4435030682
Pushed `a01a855603` — closing out the design feedback and bot threads from
the last round.
**New commits since the previous push:**
- `62d70a113b` perf(explore-controls): re-add `memo()` to FC-converted
PureComponents (SelectControl, AnnotationLayerControl,
AdhocFilterPopoverTrigger, FixedOrMetricControl, MetricsControl)
- `f021cf2060` fix(CopyToClipboard): keyboard activation for non-element
copyNode wrapper (+ regression test)
- `62808305f8` fix(TextAreaControl): restore `<ControlHeader>` as modal
title — widens `ModalTrigger.modalTitle` to `ReactNode`, drops the 12-prop
destructure for `{...restProps}`, restores `SupersetClient.get` spy via
`afterAll` in `DatasourceControl.test.tsx`
- `e8f20a67e4` fix(AnnotationLayer): stop double-fetching chart on hydration
+ inline `renderChartHeader` (was a dead `useCallback`)
- `c8a6059eaa` perf(DatasourceEditor): stop rebinding `ctrl+shift+f` on
every SQL keystroke — bind once on mount, route through refs
- `a01a855603` fix(CollectionTable): restore controlled pagination + filter
clamping
Also picked up master's recent #39796 explanatory text under the disabled
`Save (Overwrite)` radio during the rebase (needed `Typography` import in
`SaveModal.tsx`).
Threads resolved with the relevant commit SHAs in the replies. The 5
specific-test threads from @sadpandajoe
(`history.replace`/`OUT_OF_TAB`/`onDashboardChange(null)`/`partitionColumn
reset`/`fetchQueryResults retry`) are intentionally left open as trackers — the
behavior fixes for each are in this PR, the tests need scaffolding bigger than
the conversion diff should carry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
