codeant-ai-for-open-source[bot] commented on code in PR #39837:
URL: https://github.com/apache/superset/pull/39837#discussion_r3230637581
##########
docs/src/theme/DocVersionBadge/index.js:
##########
@@ -40,8 +40,8 @@ export default function DocVersionBadge() {
const isVersioned = [
'default', // main docs
'components',
- 'tutorials',
- 'developer_portal',
+ 'admin_docs',
+ 'developer_docs',
Review Comment:
**🟠Architect Review — HIGH**
DocVersionBadge assumes each pluginId directly matches the URL base path
(`basePath = '/docs'` for `default`, `basePath = '/${pluginId}'` otherwise),
but `admin_docs` and `developer_docs` actually route under `/admin-docs` and
`/developer-docs`; as a result, `versionedPath` never resolves for these
sections and the version dropdown links to the section root instead of the same
page when switching versions.
**Suggestion:** Introduce an explicit pluginId→routeBasePath map (e.g.,
`default`→`/user-docs`, `admin_docs`→`/admin-docs`,
`developer_docs`→`/developer-docs`, `components`→`/components`) and use it when
computing `basePath`/`versionedPath`, then verify version-switch behavior on
deep pages in all four sections.
[Fix in
Cursor](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20docs%2Fsrc%2Ftheme%2FDocVersionBadge%2Findex.js%0A%2A%2ALine%3A%2A%2A%2043%3A44%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20DocVersionBadge%20assumes%20each%20pluginId%20directly%20matches%20the%20URL%20base%20path%20%28%60basePath%20%3D%20%27%2Fdocs%27%60%20for%20%60default%60%2C%20%60basePath%20%3D%20%27%2F%24%7BpluginId%7D%27%60%20otherwise%29%2C%20but%20%60admin_docs%60%20and%20%60developer_docs%60%20actually%20rou
te%20under%20%60%2Fadmin-docs%60%20and%20%60%2Fdeveloper-docs%60%3B%20as%20a%20result%2C%20%60versionedPath%60%20never%20resolves%20for%20these%20sections%20and%20the%20version%20dropdown%20links%20to%20the%20section%20root%20instead%20of%20the%20same%20page%20when%20switching%20versions.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggested%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20awa
it%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
| [Fix in VSCode
Claude](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt=This%20is%20an%20%2A%2AArchitect%20%2F%20Logical%20Review%2A%2A%20comment%20left%20during%20a%20code%20review.%20These%20reviews%20are%20first-class%2C%20important%20findings%20%E2%80%94%20not%20optional%20suggestions.%20Do%20NOT%20dismiss%20this%20as%20a%20%27big%20architectural%20change%27%20just%20because%20the%20title%20says%20architect%20review%3B%20most%20of%20these%20can%20be%20resolved%20with%20a%20small%2C%20localized%20fix%20once%
20the%20intent%20is%20understood.%0A%0A%2A%2APath%3A%2A%2A%20docs%2Fsrc%2Ftheme%2FDocVersionBadge%2Findex.js%0A%2A%2ALine%3A%2A%2A%2043%3A44%0A%2A%2AComment%3A%2A%2A%0A%09%2AHIGH%3A%20DocVersionBadge%20assumes%20each%20pluginId%20directly%20matches%20the%20URL%20base%20path%20%28%60basePath%20%3D%20%27%2Fdocs%27%60%20for%20%60default%60%2C%20%60basePath%20%3D%20%27%2F%24%7BpluginId%7D%27%60%20otherwise%29%2C%20but%20%60admin_docs%60%20and%20%60developer_docs%60%20actually%20route%20under%20%60%2Fadmin-docs%60%20and%20%60%2Fdeveloper-docs%60%3B%20as%20a%20result%2C%20%60versionedPath%60%20never%20resolves%20for%20these%20sections%20and%20the%20version%20dropdown%20links%20to%20the%20section%20root%20instead%20of%20the%20same%20page%20when%20switching%20versions.%0A%0AValidate%20the%20correctness%20of%20the%20flagged%20issue.%20If%20correct%2C%20How%20can%20I%20resolve%20this%3F%20If%20you%20propose%20a%20fix%2C%20implement%20it%20and%20please%20make%20it%20concise.%0AIf%20a%20suggest
ed%20approach%20is%20provided%20above%2C%20use%20it%20as%20the%20authoritative%20instruction.%20If%20no%20explicit%20code%20suggestion%20is%20given%2C%20you%20MUST%20still%20draft%20and%20apply%20your%20own%20minimal%2C%20localized%20fix%20%E2%80%94%20do%20not%20punt%20back%20with%20%27no%20suggestion%20provided%2C%20review%20manually%27.%20Keep%20the%20change%20as%20small%20as%20possible%3A%20add%20a%20guard%20clause%2C%20gate%20on%20a%20loading%20state%2C%20reorder%20an%20await%2C%20wrap%20in%20a%20conditional%2C%20etc.%20Do%20not%20refactor%20surrounding%20code%20or%20expand%20scope%20beyond%20the%20finding.%0AOnce%20fix%20is%20implemented%2C%20also%20check%20other%20comments%20on%20the%20same%20PR%2C%20and%20ask%20user%20if%20the%20user%20wants%20to%20fix%20the%20rest%20of%20the%20comments%20as%20well.%20if%20said%20yes%2C%20then%20fetch%20all%20the%20comments%20validate%20the%20correctness%20and%20implement%20a%20minimal%20fix%0A)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is an **Architect / Logical Review** comment left during a code review.
These reviews are first-class, important findings — not optional suggestions.
Do NOT dismiss this as a 'big architectural change' just because the title says
architect review; most of these can be resolved with a small, localized fix
once the intent is understood.
**Path:** docs/src/theme/DocVersionBadge/index.js
**Line:** 43:44
**Comment:**
*HIGH: DocVersionBadge assumes each pluginId directly matches the URL
base path (`basePath = '/docs'` for `default`, `basePath = '/${pluginId}'`
otherwise), but `admin_docs` and `developer_docs` actually route under
`/admin-docs` and `/developer-docs`; as a result, `versionedPath` never
resolves for these sections and the version dropdown links to the section root
instead of the same page when switching versions.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative
instruction. If no explicit code suggestion is given, you MUST still draft and
apply your own minimal, localized fix — do not punt back with 'no suggestion
provided, review manually'. Keep the change as small as possible: add a guard
clause, gate on a loading state, reorder an await, wrap in a conditional, etc.
Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
