rusackas commented on code in PR #39750: URL: https://github.com/apache/superset/pull/39750#discussion_r3230719940
########## pyproject.toml: ########## @@ -179,7 +179,7 @@ postgres = ["psycopg2-binary==2.9.9"] presto = ["pyhive[presto]>=0.6.5"] trino = ["trino>=0.328.0"] prophet = ["prophet>=1.1.6, <2"] -redshift = ["sqlalchemy-redshift>=0.8.1, <0.9"] +redshift = ["sqlalchemy-redshift>=0.8.1, <1.1"] Review Comment: Copilot is right on the substance — this bump shouldn't merge as-is. Confirmed via PyPI: - \`sqlalchemy-redshift\` 0.8.x → \`SQLAlchemy<2.0.0,>=0.9.2\` - \`sqlalchemy-redshift\` 1.0.0 → \`SQLAlchemy<3,>=2.0.0\` Superset's core deps pin \`sqlalchemy>=1.4, <2\` (pyproject.toml). Widening this extra to \`<1.1\` puts pip in a no-win spot: either resolution fails because \`sqlalchemy-redshift==1.0.0\` requires SQLAlchemy 2+ that Superset forbids, or — depending on resolver order — SQLAlchemy gets upgraded past Superset's pin and the rest of the app breaks at runtime. Suggest holding this PR (or closing it) until Superset itself moves to SQLAlchemy 2. Once that lands, a \`<1.1\` (or \`<2\`) upper bound becomes correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
