rusackas commented on PR #38002:
URL: https://github.com/apache/superset/pull/38002#issuecomment-4437123157
Closing this dependabot bump. The v1 → v2 migration of
`react-virtualized-auto-sizer` is structural rather than a simple version bump:
- **Render prop pattern moves from `children` to a
`renderProp`/`ChildComponent` prop.** Every call site (8 components in
Superset: `JSEditorControl`, `DatasourcePanel`, `SliceAdder`, `FoldersEditor`,
`ResultSet`, `SqlEditor`, `TablePreview`, `TableExploreTree`) uses the v1
`<AutoSizer>{({width, height}) => ...}</AutoSizer>` pattern and would need to
be rewritten.
- **`disableHeight` and `disableWidth` props are removed in v2.** Five of
the eight call sites rely on these.
- **Render-prop arguments changed type from `number` to `number |
undefined`.** Every consumer that interpolates dimensions into template
literals (e.g. `width={`${width}px`}`) needs null-safety handling for the
initial render.
- **Eight test mocks** would also need to be rewritten to match the new API
surface.
Given the spread across SqlLab, Explore, and Dashboard — and that v1.0.26
has no known issues blocking Superset — the migration risk outweighs the
benefit of taking this minor maintenance release. Closing in favor of a future,
deliberate migration PR if/when the upstream changes provide a concrete
improvement we want (e.g. better TypeScript types or memoization via
`ChildComponent`).
Refs:
https://github.com/bvaughn/react-virtualized-auto-sizer/blob/main/CHANGELOG.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
