rusackas commented on PR #37201: URL: https://github.com/apache/superset/pull/37201#issuecomment-4437621335
Closing as a duplicate of the more recent #37996 (closed today with the full v1 → v2 analysis). The react-window v2 release is a complete API redesign — all named exports (`VariableSizeGrid`, `VariableSizeList`, `FixedSizeList`, `FixedSizeGrid`) are removed in favor of generic `Grid` and `List` with entirely different prop signatures (`rowComponent`/`cellComponent` + `rowProps`/`cellProps` instead of children-as-render-prop), `itemData`/`itemSize`/`itemCount`/`itemKey` removed, `ListChildComponentProps` removed, the imperative `resetAfterIndex()` API removed, and `onScroll` removed (which Superset's `VirtualTable.tsx` uses to sync the AntD table's horizontal header scrolling — no direct migration path). Affected files: 7 (`VirtualTable.tsx`, `DatasourceItems.tsx`, `VirtualizedTreeList.tsx`, `VirtualizedTreeItem.tsx`, `useAutoScroll.ts`, `SliceAdder.tsx`, `DrillBySubmenu.tsx`). This needs a focused migration PR, not a Dependabot single-shot bump. See #37996 for the full scope analysis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
