Aitema-gmbh commented on code in PR #39233:
URL: https://github.com/apache/superset/pull/39233#discussion_r3232389540
##########
superset-frontend/src/features/alerts/components/AlertStatusIcon.tsx:
##########
@@ -116,6 +111,8 @@ export default function AlertStatusIcon({
isReportEnabled,
theme,
)}
+ spin={isWorkingState}
+ aria-hidden="true"
Review Comment:
Addressed in ac869591 — removed the aria-hidden="true" from the icon so the
Tooltip-provided label (lastStateConfig.label) is now exposed to assistive
technologies. Resolving — thanks for the catch.
##########
superset-frontend/src/components/Chart/ChartErrorMessage.tsx:
##########
@@ -18,6 +18,7 @@
*/
import { ClientErrorObject, SupersetError } from '@superset-ui/core';
+import { t } from '@apache-superset/core';
Review Comment:
Addressed in ac869591 — switched import to
'@apache-superset/core/translation' to match the package's namespace exports.
Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
