Aitema-gmbh commented on code in PR #39230:
URL: https://github.com/apache/superset/pull/39230#discussion_r3232525865
##########
superset-frontend/src/SqlLab/components/ShareSqlLabQuery/index.tsx:
##########
@@ -79,7 +79,7 @@ const ShareSqlLabQuery = ({
margin-right: 0;
}
`}
- icon={<Icons.LinkOutlined iconSize="m" />}
+ icon={<Icons.LinkOutlined iconSize="m" aria-hidden="true" />}
Review Comment:
Addressed in 196ed7c6 — removed aria-hidden so Icons.LinkOutlined exposes
its auto-generated accessible name via BaseIcon. Resolving — thanks for the
catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
