Aitema-gmbh commented on code in PR #39236:
URL: https://github.com/apache/superset/pull/39236#discussion_r3232702334
##########
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx:
##########
@@ -48,7 +48,7 @@ import {
SunburstChart,
CustomChart,
} from 'echarts/charts';
-import { CanvasRenderer } from 'echarts/renderers';
+import { SVGRenderer } from 'echarts/renderers';
Review Comment:
Addressed in 159a5aa7 (explicit `renderer: 'svg'` in `init()`) and refined
in 838a5a46 — both `CanvasRenderer` and `SVGRenderer` are now registered, and
the init call selects `'svg'` only when the `ACCESSIBLE_CHART_RENDERING`
feature flag is on. Default stays on canvas, so the performance fallback you
mentioned is preserved. Resolving — thanks for the catch.
##########
superset-frontend/plugins/plugin-chart-echarts/src/components/Echart.tsx:
##########
@@ -48,7 +48,7 @@ import {
SunburstChart,
CustomChart,
} from 'echarts/charts';
-import { CanvasRenderer } from 'echarts/renderers';
+import { SVGRenderer } from 'echarts/renderers';
Review Comment:
Addressed in 159a5aa7 (explicit `renderer: 'svg'` in `init()`) and refined
in 838a5a46 — both `CanvasRenderer` and `SVGRenderer` are now registered, and
the init call selects `'svg'` only when the `ACCESSIBLE_CHART_RENDERING`
feature flag is on. Default stays on canvas, so the performance fallback you
mentioned is preserved. Resolving — thanks for the catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
