Aitema-gmbh commented on code in PR #39242:
URL: https://github.com/apache/superset/pull/39242#discussion_r3232767531


##########
superset-frontend/src/filters/components/Time/TimeFilterPlugin.tsx:
##########
@@ -62,8 +62,8 @@ const ControlContainer = styled.div<{
 
   &:focus > div {

Review Comment:
   VALID-FOLLOWUP. Noted — `TimeFilterPlugin`'s focus styling on `:focus` 
rather than `:focus-visible` does mean the custom ring can paint on 
mouse-driven focus. Worth flagging that @rusackas separately requested that the 
`controlOutline → colorPrimary` swap in this file be reverted, so the path 
forward in the follow-up may supersede this `:focus` vs `:focus-visible` change 
entirely. Will reconcile both in the cleanup pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to