matebenyovszky commented on PR #39171: URL: https://github.com/apache/superset/pull/39171#issuecomment-4439896837
Hi @michael-s-molina — I've opened a PR directly against your `extensions-storage-tiers-1-2` branch with the bug fix and tests: **PR: https://github.com/michael-s-molina/superset/pull/775** ### What's in it: **Bug fix** — Frontend `ephemeralState.ts` and `persistentState.ts` URL builders don't match the backend's `/{publisher}/{name}/storage/{tier}/{key}` routes (introduced in f08bcd4). All frontend storage API calls currently 404. **Tests (472 lines)** — Unit tests for all three storage modules (`localState`, `ephemeralState`, `persistentState`) covering CRUD, shared access, URL encoding, and validation. Should resolve the `codecov/project/core-packages-ts` CI failure. ### What I think is still needed to merge #39171: 1. ✅ **Frontend URL bug** — fixed in my PR 2. ✅ **Frontend tests** — included in my PR 3. ⬜ **Backend Python tests** — `api.py` at 0%, `persistent_state_dao.py` at 32%, `ephemeral_state.py` at 45% (happy to write these too) 4. ⬜ **Mark as Ready for Review** — still Draft 5. ⬜ **Re-review from @villebro** — earlier comments were all addressed I noticed @rusackas just referenced this PR from `michael-s-molina/superset#774` — the extensions ecosystem is moving fast and Storage API is a foundational piece. Let me know if there's anything else I can do to help! 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
