Copilot commented on code in PR #39705: URL: https://github.com/apache/superset/pull/39705#discussion_r3236279776
########## docs/developer_docs/contributing/development-setup.md: ########## @@ -577,7 +577,7 @@ sudo sysctl -p #### Webpack dev server -The dev server by default starts at `http://localhost:9000` and proxies the backend requests to `http://localhost:8088`. +The dev server by default starts at `http://localhost:8088` and proxies the backend requests to `http://localhost:8088`. Review Comment: The Webpack dev server cannot start on the same port (8088) that it proxies backend requests to — that would conflict with the Flask backend started via `superset run -p 8088` in the steps that follow. The Webpack dev server default is port 9000 (see `superset-frontend/webpack.config.js`), and only the Docker Compose setup serves Superset on 8088. This section (and the related changes on lines 351, 591, 597, and 602 referring to `npm run dev` / `npm run dev-server`) should remain at port 9000. Please revert these dev-server related changes and keep only the Docker Compose change on line 74. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
