anthonyhungnguyen commented on issue #39492:
URL: https://github.com/apache/superset/issues/39492#issuecomment-4443727354
Hey @mikebridge, quick clarifications on a few of those points:
On the deployment friction — the "BYOR" framing kind of undersells it. The
default mode is
just a single org-wide repo configured once by an admin at deploy time. End
users never see
Git; they save and restore through the Superset UI like normal. The per-user
repo headers
are an opt-in for power users who want their own bucket, not the primary
path. So for most
installs it's "set up one repo at deploy time," not "everyone needs Git."
On the extension idea — yeah, I think that's the right framing. The two
approaches really do
solve different problems and shouldn't be competing for the same
persistence layer. SIP-210
makes sense for the in-DB queryable history (per-field diffs, ETag, all the
stuff the V2 UI
needs), and an external-store extension makes sense for deployments that
want zero DB
footprint and the audit trail somewhere their security/legal team already
watches. If the
extension exposes a couple of clean hooks (on_entity_saved, restore), it can
either layer on
top of SIP-210 or stand alone — operators get to pick.
And on is_managed_externally — yeah, this is actually one of the cases where
the external
store feels more natural to me, because the data is already managed
externally. Git history
complements the Terraform/CI workflow instead of duplicating it inside
Superset. Our current
behaviour is that restore is still allowed but just produces a normal save,
which the next
external sync overwrites — so it stays a temporary recovery action rather
than a permanent
override. An on_restore hook could tighten that up further if you wanted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
