Copilot commented on code in PR #39740:
URL: https://github.com/apache/superset/pull/39740#discussion_r3236300933
##########
superset-frontend/plugins/plugin-chart-handlebars/README.md:
##########
@@ -93,3 +93,15 @@ Below, you will find a list of all currently registered
helpers in the Handlebar
4. **`parseJson`**: Parses a JSON string into a JavaScript object.
- **Usage**: `{{parseJson jsonString}}`.
+
+5. **eq**: Returns true if values are equal.
+ - **Usage**: {{eq a b}}
+
+6. **neq**: Returns true if values are not equal.
+ - **Usage**: {{neq a b}}
+
+7. **gt**: Returns true if a > b.
+ - **Usage**: {{gt a b}}
+
+8. **lt**: Returns true if a < b.
+ - **Usage**: {{lt a b}}
Review Comment:
The new helper entries are formatted inconsistently with the existing ones:
earlier items wrap helper names and usage examples in inline code (backticks)
and end usage lines with a period. Consider updating these to match the
established style (e.g., **`eq`** and `{{eq a b}}`).
##########
superset-frontend/plugins/plugin-chart-handlebars/README.md:
##########
@@ -93,3 +93,15 @@ Below, you will find a list of all currently registered
helpers in the Handlebar
4. **`parseJson`**: Parses a JSON string into a JavaScript object.
- **Usage**: `{{parseJson jsonString}}`.
+
Review Comment:
Line 96 appears to be a blank line containing trailing whitespace. Please
remove trailing spaces to avoid unnecessary whitespace-only diffs and keep
Markdown files clean.
##########
superset-frontend/plugins/plugin-chart-handlebars/README.md:
##########
@@ -93,3 +93,15 @@ Below, you will find a list of all currently registered
helpers in the Handlebar
4. **`parseJson`**: Parses a JSON string into a JavaScript object.
- **Usage**: `{{parseJson jsonString}}`.
+
+5. **eq**: Returns true if values are equal.
Review Comment:
The PR description checklist indicates both 'Changes UI' and 'Includes DB
Migration', but this diff only updates a README. Please update the PR
description/checklist to accurately reflect the scope of changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
