betodealmeida opened a new pull request, #40097: URL: https://github.com/apache/superset/pull/40097
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When we do OAuth2, we open a new tab and send the user to authorize the access from Superset. After authorizing, the tab receives the token (access and possibly refresh), stores in the DB, auto-closes, and send a message to the initial tab to rerun the query. Unfortunately `window.opener.postMessage` was failing because modern browser COOP policies (and the `rel="noreferrer"` on the auth link itself) leave `window.opener` as `null` once the new tab navigates cross-origin to the OAuth provider, so neither the message nor `window.close()` ran. The user had to manually close the tab and manually retrigger the query. This PR fixes it by switching to `BroadcastChannel('oauth')`, which works tab-to-tab as long as both pages are same-origin (both are served by Superset). The `tab_id` remains the security check that pairs a callback to its initiating tab. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> N/A ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
